Skip to content

Add messaging v1.43 shared contract#19266

Draft
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:messaging-v1-43-contract
Draft

Add messaging v1.43 shared contract#19266
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:messaging-v1-43-contract

Conversation

@trask

@trask trask commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Dependency baseline: 42f8313f8fd213cfc1e68c87e7ffa73e0237bdb9.
Review only: 42f8313f8fd213cfc1e68c87e7ffa73e0237bdb9..653c0b1d622f3fb3b9be44a0c205d3d37dcd2214.

Exactly one contract-owned commit. Legacy MessageOperation factories remain legacy; typed factories are selector-aware; convenience typed creation requires a non-null operation type.

Validation: incubator default/stable/dual extractor tests, Kafka 0.11 stable-semconv task, Spotless.

@opentelemetry-pr-dashboard opentelemetry-pr-dashboard Bot mentioned this pull request Jul 19, 2026
Open
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-22 16:49:27 UTC.

  • Waiting on: Author
  • Next step: Move out of draft to request review.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

This was referenced Jul 19, 2026
Draft
Closed
@trask

trask commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

/review

github-actions[bot]
github-actions Bot reviewed Jul 19, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one API compatibility issue in the messaging semconv overloads.

Triggered by: /review by @trask. Model: gpt-5.5.

@trask

trask commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

The automated review found a source-compatibility issue, but its inline comment was skipped because it targeted an unchanged line. I recovered the finding from workflow artifact 29700162444: the same-arity MessageOperation and MessagingOperationType overloads made null-literal calls ambiguous. Commit cec4e571d3 gives the new typed factories distinct names and adds direct null-literal regression coverage. Default, preview, dual-emission, and Spotless checks pass.

@trask

trask commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

/review

github-actions[bot]
github-actions Bot reviewed Jul 19, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue in the new messaging semconv stability helper.

Triggered by: /review by @trask. Model: gpt-5.5.

Comment thread ...va/io/opentelemetry/instrumentation/testing/junit/message/SemconvMessagingStabilityUtil.java Outdated
@trask
trask requested a review from Copilot July 19, 2026 19:37
Copilot AI reviewed Jul 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the shared messaging v1.43 semantic-convention contract while retaining legacy compatibility and version-aware javaagent bridging.

Changes:

  • Adds operation types, attributes, span names, kinds, and error types.
  • Adds exact messaging span keys and compatibility bridges.
  • Expands selector, compatibility, and extractor tests.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
testing-common/.../SemconvMessagingStabilityUtil.java Maps legacy assertion keys.
.../testing/AgentSpanTestingInstrumenter.java Includes new span keys.
.../v1_14/ContextBridgeTest.java Tests bridging new keys.
.../v1_14/SpanKeyBridging.java Bridges keys across API versions.
instrumentation-api/.../SemconvStabilityTest.java Tests messaging selection modes.
instrumentation-api/.../SpanKey.java Defines create and settle keys.
instrumentation-api/.../SemconvStability.java Clarifies messaging selection accessors.
.../MessagingSpanNameExtractorTest.java Tests version-dependent names.
.../MessagingSpanKindExtractorTest.java Tests messaging span kinds.
.../MessagingAttributesExtractorTest.java Tests attributes and compatibility.
.../MessagingSpanNameExtractorBuilder.java Adds configurable operation names.
.../MessagingSpanNameExtractor.java Implements v1.43 span naming.
.../MessagingSpanKindExtractor.java Implements version-aware span kinds.
.../MessagingOperationType.java Defines v1.43 operation types.
.../MessagingAttributesGetter.java Adds error-type extraction.
.../MessagingAttributesExtractorBuilder.java Configures operation metadata.
.../MessagingAttributesExtractor.java Emits selected messaging conventions.
.../MessageOperation.java Delegates legacy operations.
instrumentation-api-incubator/build.gradle.kts Enables messaging preview test modes.

Comment thread ...pentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingSpanNameExtractor.java Outdated
@trask
trask requested a review from Copilot July 19, 2026 19:46
Copilot AI reviewed Jul 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-contract branch from bd2da26 to 751c975 Compare July 19, 2026 20:11
@trask
trask requested a review from Copilot July 19, 2026 20:11
Copilot AI reviewed Jul 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask trask mentioned this pull request Jul 20, 2026
Draft
@trask
trask force-pushed the messaging-v1-43-contract branch from 751c975 to 314728b Compare July 21, 2026 00:18
@trask
trask requested a review from Copilot July 21, 2026 00:19
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Comment thread ...ntelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractor.java Outdated
@trask
trask requested a review from Copilot July 21, 2026 00:29
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-contract branch from 3b683c2 to 9dc5bef Compare July 21, 2026 01:06
@trask
trask requested a review from Copilot July 21, 2026 01:06
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Comment thread ...try/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorBuilder.java
Comment thread ...try/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorBuilder.java Outdated
@trask
trask requested a review from Copilot July 21, 2026 01:17
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-contract branch from fa6ce6c to 496b2ae Compare July 21, 2026 01:45
@trask
trask requested a review from Copilot July 21, 2026 01:46
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask trask mentioned this pull request Jul 21, 2026
Draft
@trask
trask force-pushed the messaging-v1-43-contract branch from 496b2ae to 653c0b1 Compare July 21, 2026 02:43
@trask
trask requested a review from Copilot July 21, 2026 02:47
Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

@trask trask mentioned this pull request Jul 21, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trask